Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning message in TID manager when OIDs cannot be found #954

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

gacarrillor
Copy link
Collaborator

@gacarrillor gacarrillor commented Aug 19, 2024

Fix #925

image

@gacarrillor gacarrillor reopened this Aug 19, 2024
@signedav
Copy link
Member

Code looks good but I wonder if a message box would be nicer. This Warning Bar for me looks like an error and not like an information that it does not make sense to use this dialog. Maybe just grayed out everything makes sense as well.

@gacarrillor
Copy link
Collaborator Author

Code looks good but I wonder if a message box would be nicer. This Warning Bar for me looks like an error and not like an information that it does not make sense to use this dialog. Maybe just grayed out everything makes sense as well.

I'll try with a message box to let the user know why the dialog is grayed out.

@gacarrillor
Copy link
Collaborator Author

@signedav, BTW, yesterday I think I finally did it with a message bar because I saw we had this message for a similar case in the Dataset Manager (i.e., empty project, probably first time opening Model Baker dialogs):

image

Should we bring a message box also for this Dataset Manager or we leave it as is and implement a message box for the OID Manager anyways?

@signedav
Copy link
Member

Hm... Looks cleaner when we only have one row. So less strong opinion meanwhile. What is your opinion? Both box or both bar?

@gacarrillor
Copy link
Collaborator Author

Hm... Looks cleaner when we only have one row. So less strong opinion meanwhile. What is your opinion? Both box or both bar?

I'd prefer both with message bars, although I agree, it looks a bit overwhelming when we have more than one line. Perhaps we can rephrase it to make it fit into one line. The "Warning:" title could also be dropped to save space.

Another attempt (not sure it that will fit, apparently I have my verbose mode activated):
To use the OID Manager, first configure a connection to an Interlis database in the Import/Export Wizard.

If you have a shorter alternative, please let me know.

@signedav
Copy link
Member

To use the OID Manager, configure a connection to an INTERLIS based database.

@gacarrillor
Copy link
Collaborator Author

To use the OID Manager, configure a connection to an INTERLIS based database.

Thanks, screenshot updated and changes applied.

@gacarrillor gacarrillor changed the title Show warning message in TID manager when OIDs cannot be find Show warning message in TID manager when OIDs cannot be found Aug 20, 2024
@signedav signedav merged commit c8863b1 into master Aug 22, 2024
3 of 7 checks passed
@signedav signedav deleted the fix_925 branch August 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OID manager does not open when there are no layers in QGIS LayerTree
2 participants