Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modification of baskets and datasets #955

Merged
merged 14 commits into from
Nov 4, 2024
Merged

Modification of baskets and datasets #955

merged 14 commits into from
Nov 4, 2024

Conversation

gacarrillor
Copy link
Collaborator

@gacarrillor gacarrillor commented Aug 26, 2024 •
edited
Loading

  • Adapt Basket Manager and Create Basket dialogs, as well as their underlying models.
  • Edit basket attributes.
  • Change dataset of a basket.
  • Delete basket.
  • Delete dataset.

Screenshots

Edit basket:
image

Depends on opengisch/QgisModelBakerLibrary#107

@gacarrillor
[gui] Homogenize the dataset manager dialog: add/edit/remove buttons …
d29c419 
…and add tooltips for them; homogenize subdialog names (create/edit dataset)
@gacarrillor
[gui] Convert current Basket manager into Create Basket dialog
95376dc
@gacarrillor
[gui] Introduce brand new new Basket Manager (still partial)
73c491d
@gacarrillor
[gui] Adapt BasketManager and CreateBasket dialogs, as well as their …
8a746d7 
…corresponding models. The former will list only existing baskets, whereas the latter will show only non-existing ones.
@gacarrillor
[gui] Introduce EditBasketDialog, load info from the selected basket …
91e423f 
…in BasketManager; for changing the selected basket's dataset, disable datasets that already have a basket for the selected basket's topic (since we shouldn't have 2 baskets for the same topic in the same dataset)
@gacarrillor
[gui] Add edit basket support
504d16a
@gacarrillor
[gui] Trigger basket edit on basket managet item double click
3130538
@gacarrillor
[gui] Allow users to set the attachment key during basket creation
8802d2c
@gacarrillor
[git] Add Delete Dataset support
67f47c7
@gacarrillor
[gui] Add Delete Basket support; introduce ili2db_utils module to exe…
c074485 
…cute common ili2db operations via Model Baker Library
@gacarrillor gacarrillor marked this pull request as ready for review September 29, 2024 03:00
@signedav
Copy link
Member

signedav commented Oct 1, 2024

Tested it on PG and it runs pretty smooth. Two minor GUI inputs:

  • Maybe "edit" and "remove" icon can be depending on selection.
  • The BID (OID Type) looks like expecting something. Can't we grey it out?
    image

Code review will follow...

signedav
signedav approved these changes Oct 1, 2024
View reviewed changes
QgisModelBaker/utils/ili2db_utils.py Outdated Show resolved Hide resolved
QgisModelBaker/utils/ili2db_utils.py Outdated Show resolved Hide resolved
QgisModelBaker/gui/basket_manager.py Show resolved Hide resolved
@gacarrillor
Copy link
Collaborator Author

Tested it on PG and it runs pretty smooth. Two minor GUI inputs:

* Maybe "edit" and "remove" icon can be depending on selection.
* The BID (OID Type) looks like expecting something. Can't we grey it out?

Addressed in the latest commits.

(After a while playing with colors...) Let's disable those read-only fields :)
It's better for you as well?

image

@signedav
Copy link
Member

signedav commented Oct 7, 2024

Good to merge after a new library release...

@gacarrillor gacarrillor mentioned this pull request Oct 31, 2024
Closed
@signedav signedav merged commit d26fba0 into master Nov 4, 2024
7 checks passed
@signedav signedav deleted the modification_baskets_datasets branch November 4, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@signedav signedav signedav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gacarrillor @signedav