ALLOW headers in response to OPTIONS requests should reflect the request's permissions #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why-not-try-calmer
force-pushed
the
http-verbs-in-headers-matching-request-permissions
branch
4 times, most recently
from
5f7b4af
to
d4f17e1
Compare
| self.assertEqual(allowed_body, expected) | ||
| self.assertEqual(allowed_headers, allowed_body) | ||
|
|
||
| def test_admin_items_options(self): |
There was a problem hiding this comment.
@3nids This test (test_admin_items_options) passes. This means that QGIS will get correct responses to its authenticated OPTIONS requests, doesn't it?
cleanup tests; added tests for options given new metadata class
why-not-try-calmer
force-pushed
the
http-verbs-in-headers-matching-request-permissions
branch
from
d4f17e1
to
0305ae8
Compare
why-not-try-calmer
changed the title
why-not-try-calmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not work yet (hence the Draft). But it will soon.