Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring unit tests; reformatted test.yaml #93

Closed
wants to merge 3 commits into from

Conversation

why-not-try-calmer
Copy link
Contributor

No description provided.

@github-actions
Copy link

Oh no! Conformance tests got worse!

@why-not-try-calmer
Copy link
Contributor Author

why-not-try-calmer commented Sep 29, 2023

@3nids It looks like recent commits pushed to main that introduced encoding to JSON from the database were not followed through with adjustments to unit tests. Is it okay to expect the authors of the said commits to make the relevant changes?

#89 is ready and I rebased it on this very PR to make it have its unit tests use the new structure.

@why-not-try-calmer why-not-try-calmer changed the title Rescued unit tests; reformatted test.yaml Restoring unit tests; reformatted test.yaml Sep 29, 2023
@3nids
Copy link
Member

3nids commented Oct 5, 2023

it is fixed now

@3nids 3nids closed this Oct 5, 2023
@why-not-try-calmer
Copy link
Contributor Author

why-not-try-calmer commented Oct 5, 2023

? But this PR moves the tests where you suggested, under a self-contained test module. Isn't that what you recommended?

@3nids 3nids deleted the restoring-unit-tests branch October 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants