Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy LICENCE file from root directory to plugin package #255

Closed
jmkerloch opened this issue Nov 23, 2023 · 6 comments
Closed

Copy LICENCE file from root directory to plugin package #255

jmkerloch opened this issue Nov 23, 2023 · 6 comments

Comments

@jmkerloch
Copy link

We have some issue when using latest version (qgis-plugin-ci-2.8.1): https://gitlab.com/Oslandia/qgis/qwc2_tools/-/jobs/5598167137#L306

$ qgis-plugin-ci release ${CI_COMMIT_TAG} --allow-uncommitted-changes --osgeo-username $OSGEO_USER_NAME --osgeo-password $OSGEO_USER_PASSWORD
2023-11-22 17:24:14||ERROR||release||=== A fault occurred occurred ===
Fault code: 1
Fault string: <Fault 1: 'File upload must be a valid QGIS Python plugin compressed archive. Cannot find LICENSE in plugin package.'>

This seems to come from this commit of QGIS plugin repository : qgis/QGIS-Django@91b9576

# Checks for LICENCE file precense
    licensename = package_name + "/LICENSE"
    if licensename not in namelist:
        raise ValidationError(_("Cannot find LICENSE in plugin package."))

Do you think we should copy LICENCE file from root directory to plugin package ?

This will avoid a copy of the file in the CI.

@Gustry
Copy link
Collaborator

Gustry commented Nov 23, 2023

If the file exists in the root directory, I would say yes, let's package it.

@Guts
Copy link
Collaborator

Guts commented Nov 23, 2023

I let a comment on the issue to ask for reverting this breaking change in favor of a more open community driven change process: qgis/QGIS-Django#38

@m-kuhn
Copy link
Member

m-kuhn commented Jul 25, 2024

I think this has become relevant again, a LICENSE file is required since June.

Fault string: <Fault 1: 'File upload must be a valid QGIS Python plugin compressed archive. Cannot find LICENSE in the plugin package. This file is required, please consider adding it to the plugin package.'>

qgis/QGIS-Django#410

@Guts
Copy link
Collaborator

Guts commented Jul 25, 2024

I've fixed that on my side. I try to push before the week-end.

@nirvn
Copy link
Member

nirvn commented Aug 1, 2024

@Guts , just saw your comment in this issue after opening the following PR (#307). Feel free to review that or supersede it with something better :)

@Guts
Copy link
Collaborator

Guts commented Aug 1, 2024

@Guts , just saw your comment in this issue after opening the following PR (#307). Feel free to review that or supersede it with something better :)

Hello @nirvn,

No worries. My delay have expired for some days already.
Not sure to be able to do better 😅. I'll have a look to your PR.

@Gustry Gustry closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants