-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If LICENSE is missing from the plugin path but available in the parent path when packaging, include that #307
Conversation
…t path when packaging, include that
Fixes #255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks.
Can you just add a check in the test ? Similar to https://github.com/opengisch/qgis-plugin-ci/blob/master/test/test_release.py#L198
Just that the file exists for instance, as the LICENSE
exists in the parent folder.
It seems the test is failing on the LICENCE file now : For the false positive about transifex, for next time, you can push your work branch on the main git repo opengisch, it will launch the test suite without any issue in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for fulfilling the task that I should have done.
Just for the beauté du geste, recently I try to work only with pathlib to deal with files and reserve shutil (or other lower-level libs) for special cases. And it's possible to use pathlib to move a file (rename) or copy one touch + write_text in oneliner.
@Gustry , I'll seek to gain push permission into this repository :) |
@Gustry , license test failure fixed. |
Shall we do a new release? |
CI is running for 2.8.9 ;-) |
@m-kuhn , @suricactus , as discussed to fix qfieldsync releases.