jsr223.md: do not state that SimpleRule is used only in Jython #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
dilyanpalauzov
force-pushed
the
jsr223_no_jython_simple_rule
branch
from
39015ec
to
5fdee48
Compare
|
Why is the CI failing in configuration/transformations.md, when I have not modified this file? |
|
There appear to be some markdown linting errors that made it into the merged version. I'm not sure how that happened nor the best way to handle that. You can fix it obviously as part of this PR but it would be good to know why this is showing up. Maybe the linting rules changed? |
dilyanpalauzov
force-pushed
the
jsr223_no_jython_simple_rule
branch
from
5fdee48
to
2cf2f7f
Compare
|
I do not understand it. #2358 does pass the linter checks and there configuration/transforms.md is the same. The problem with transforms.md is that there is a numbered list, in which since 20 August not all items start with |
dilyanpalauzov
force-pushed
the
jsr223_no_jython_simple_rule
branch
from
2cf2f7f
to
23542d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify example for Groovy closure. I believe its form is not
() -> {…}, but{ [params ->] … }where params is optional, and -> is also optional when there are no params, cf. https://groovy-lang.org/closures.htmlFor RuleSimple preset insert hyperlinks to the documentation of the included classes.
Remove statement that SimpleRule is a base class for Rules only in Jython.