Add support for SUSE family distros (tested on OpenSUSE) to installation script #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of the installations actually succeeded. The failures were all caused by Verilator failing regression with the updated Verilog Ethernet suite from #1135 |
|
Hmm. Strange that SUSE is failing. It worked when I tested it locally. Will investigate. |
|
Oh. It’s downloading the site-setup.sh script from the main repository, which doesn’t have the changes needed to support SUSE that are included in this PR. The installation was successful but the path was configured wrong for regression because of that. Should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one major family of Linux distros that still wasn't supported was SUSE. This adds support for the latest version of OpenSUSE Leap (and should be compatible with SLES as well). Besides RHEL, this is the other major distro supported by EDA tool vendors, so it seemed worthwhile to include. Especially because it was very little effort to add after the recent refactoring of the scripts.
I also took the chance to do additional refactoring of the installation script for improved maintenance and readability.