Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt at Ubuntu derivative distro support, focusing on Linux Mint #1188

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

jordancarlin
Copy link
Member

Update version detection logic to handle Ubuntu derivatives. Installation is still known to be failing on Linux Mint 22 because of other issues I'm still troubleshooting. Pushing this for now because it may solve the issues in Linux Mint 21 without further changes.

I'm not going to list Ubuntu derivatives as officially supported by the installation script because we won't be testing on all of them, but if we can make it work most of the time that would still be great.

@jordancarlin
Copy link
Member Author

Looks like something happened related to authentication with the Red Hat builds. Traced it back to an updated version of PAM. It's unrelated to this change, so assuming the other distros pass CI we can merge this. I'll investigate that separately and open another PR with a workaround when I figure something out.

@PietDelaney
Copy link

Looks good using /etc/os-release:

UBUNTU_CODENAME=jammy

for Linux Mint 21.3

With Gerrit its easy to checkout a proposed commit. I haven't figured out how to do it with this github code review framework.

@jordancarlin
Copy link
Member Author

@PietDelaney thanks for the confirmation regarding the UBUNTU_CODENAME on 21.3.

For future reference, if you have the GitHub CLI installed (gh) you can checkout a PR by running gh pr checkout $ID. Otherwise you can run the following sequence of git commands:

git fetch origin pull/$ID/head:$BRANCHNAME
git checkout $BRANCHNAME

where $ID is the PR number and $BRANCHNAME is the name of the local branch you want to create. If the OpenHWGroup repo is not the origin repo (which might be the case if you cloned a fork as the origin) then change origin accordingly (likely to upstream).

@davidharrishmc davidharrishmc merged commit b9ec056 into openhwgroup:main Dec 10, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants