Merge pull request #124 from openinfradev/TKS-802

bugfix. remove http status '204 empty'
openinfradev · Aug 2, 2023 · 763ffab · 763ffab
2 parents 0841ae5 + 8c83023
commit 763ffab
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/internal/delivery/http/user.go b/internal/delivery/http/user.go
@@ -182,11 +182,6 @@ func (u UserHandler) List(w http.ResponseWriter, r *http.Request) {
 	}
 	users, err := u.usecase.ListWithPagination(r.Context(), organizationId, pg)
 	if err != nil {
-		if _, status := httpErrors.ErrorResponse(err); status == http.StatusNotFound {
-			ResponseJSON(w, r, http.StatusNoContent, domain.ListUserResponse{})
-			return
-		}
-
 		log.ErrorfWithContext(r.Context(), "error is :%s(%T)", err.Error(), err)
 		ErrorJSON(w, r, err)
 		return

diff --git a/internal/repository/user.go b/internal/repository/user.go
@@ -195,9 +195,6 @@ func (r *UserRepository) ListWithPagination(pg *pagination.Pagination, organizat
 		log.Errorf("error is :%s(%T)", res.Error.Error(), res.Error)
 		return nil, res.Error
 	}
-	if res.RowsAffected == 0 {
-		return nil, httpErrors.NewNotFoundError(httpErrors.NotFound, "", "")
-	}
 
 	var out []domain.User
 	for _, user := range users {