Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement tks-issues-1038 #232

Merged
merged 7 commits into from
Feb 20, 2024
Merged

implement tks-issues-1038 #232

merged 7 commits into from
Feb 20, 2024

Conversation

robertchoi80
Copy link
Contributor

  • make appserving belongs to project
  • add new APIs to return task list and detail

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 14, 2024
View reviewed changes
internal/repository/app-serve-app.go Dismissed Show dismissed Hide dismissed
@robertchoi80 robertchoi80 force-pushed the tks-issues-1038 branch 2 times, most recently from 54f01f4 to 7510346 Compare February 16, 2024 04:42
@ktkfree
Copy link
Contributor

ktkfree commented Feb 19, 2024

이 PR 이 merge 되면 당분간 dev 환경에서 앱서빙은 불가능하겠군요. 개발자들이 인지하고 있어야겠습니다.

@robertchoi80
Copy link
Contributor Author

이 PR 이 merge 되면 당분간 dev 환경에서 앱서빙은 불가능하겠군요. 개발자들이 인지하고 있어야겠습니다.

네. tks-console에서 변경된 API url 들을 적용하기 전까진 불가능할 거 같습니다.

@robertchoi80 robertchoi80 merged commit 068d501 into develop Feb 20, 2024
4 of 6 checks passed
@robertchoi80 robertchoi80 deleted the tks-issues-1038 branch April 16, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktkfree ktkfree ktkfree approved these changes

@Siyeop Siyeop Awaiting requested review from Siyeop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertchoi80 @ktkfree