Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing docker compose files #1512

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Missing docker compose files #1512

merged 4 commits into from
Nov 24, 2023

Conversation

egdmrsy
Copy link
Contributor

@egdmrsy egdmrsy commented Nov 15, 2023 •
edited by SamuelPull
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Closes #1263

@egdmrsy egdmrsy self-assigned this Nov 15, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

Warnings
⚠️

Make sure the Organization-Vault-Secret is the same in all .env_example files

Generated by 🚫 dangerJS against e6c5408

@egdmrsy egdmrsy requested a review from SamuelPull November 15, 2023 11:02
@openkfwCI
Copy link

openkfwCI commented Nov 15, 2023 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededThu, 23 Nov 2023 11:32:10 +0000

Generated by E2E-Test

@egdmrsy egdmrsy requested a review from georgimld November 16, 2023 08:18
@egdmrsy egdmrsy force-pushed the 1263-missing-dc-files branch from 2b0a00c to 121b66d Compare November 16, 2023 12:15
georgimld
georgimld reviewed Nov 20, 2023
View reviewed changes
e2e-test/.nsprc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 3 .nsprc files could be deleted since they're empty

@SamuelPull SamuelPull force-pushed the 1263-missing-dc-files branch from 121b66d to e6c5408 Compare November 23, 2023 11:14
@SamuelPull SamuelPull merged commit 57818e4 into main Nov 24, 2023
28 checks passed
@SamuelPull SamuelPull deleted the 1263-missing-dc-files branch November 24, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgimld georgimld georgimld left review comments

@SamuelPull SamuelPull SamuelPull approved these changes

Assignees

@egdmrsy egdmrsy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create missing docker-compose files
4 participants
@egdmrsy @openkfwCI @SamuelPull @georgimld