Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm components for frontend #19

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

inistor
Copy link
Contributor

@inistor inistor commented Jul 25, 2024

Problem

Many of the frontend dependencies (node) are quite old and in need of an update

Approach

As I'm not very "front-end" proficient, I used advice from the net on how to perform the update, so I'd appreciate a check

The following commands were used for the update, in the frontend directory:

# npx npm-check-updates -u

This updated the package.json file.

# npm update

This updated the package-lock.json file.

Additional notes

Updating the Typescript module from 4.x to 5.x has caused some issues with the tsconfig.config.json and tsconfig.json files. While I don't understand how those work, I found a note in the vue/tsconfig repo indicating some changes needed following the upgrade of from <5.0. Among them, using tsconfig.dom.json instead of tsconfig.web.json. In addition, it is indicated there that the tsconfig.node.json file has been removed - so I've removed the "extends": "@vue/tsconfig/tsconfig.node.json" from the tsconfig.config.json file. Hope that's the correct approach.

I've ran some basic test, all seems fine.

@inistor
Copy link
Contributor Author

inistor commented Jul 31, 2024

@matthill maybe you have some time to review/comment/approve this PR?

@matthill
Copy link
Contributor

Thank you for these updates. lgtm.

@matthill matthill merged commit 1c627d7 into openkilt:master Aug 13, 2024
@inistor inistor deleted the update-frontend-components branch August 14, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants