Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed example LAMMPS SM #90

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

ilia-nikiforov-umn
Copy link

Fixes issue #89

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.28% 🎉

Comparison is base (378406f) 45.29% compared to head (110a6ed) 45.58%.

❗ Current head 110a6ed differs from pull request most recent head 2ef1a79. Consider uploading reports for the commit 2ef1a79 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel      #90      +/-   ##
==========================================
+ Coverage   45.29%   45.58%   +0.28%     
==========================================
  Files         140      140              
  Lines       13059    13154      +95     
  Branches     1338     1341       +3     
==========================================
+ Hits         5915     5996      +81     
- Misses       6476     6486      +10     
- Partials      668      672       +4     

see 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannick-couzinie
Copy link

Was writing some tests with this SM here and can confirm that this fix was needed to make the tests work, thank you for saving me some time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants