fix: fix bridge with getStringProperty on InputElement.

openkraken · Jun 2, 2021 · ea52672 · ea52672
1 parent a5d0420
commit ea52672
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/bridge/bindings/jsc/DOM/element.cc b/bridge/bindings/jsc/DOM/element.cc
@@ -765,6 +765,7 @@ BoundingClientRect::BoundingClientRect(JSContext *context, NativeBoundingClientR
  : HostObject(context, "BoundingClientRect"), nativeBoundingClientRect(boundingClientRect) {}
 
 JSValueRef ElementInstance::getStringValueProperty(std::string &name) {
+ getDartMethod()->flushUICommand();
  JSStringRef stringRef = JSStringCreateWithUTF8CString(name.c_str());
  NativeString *nativeString = stringRefToNativeString(stringRef);
  NativeString *returnedString = nativeElement->getStringValueProperty(nativeElement, nativeString);

diff --git a/integration_tests/specs/dom/nodes/element.ts b/integration_tests/specs/dom/nodes/element.ts
@@ -57,4 +57,10 @@ describe('DOM Element API', () => {
  expect(container.children[0]).toBe(a);
  expect(container.children[1]).toBe(b);
  });
+
+ it('should work with string value property', () => {
+ let input = document.createElement('input');
+ input.value = 'helloworld';
+ expect(input.value).toBe('helloworld');
+ });
 });