fix formal errors

openmindculture · Apr 3, 2024 · 88b6b27 · 88b6b27
1 parent d39109d
commit 88b6b27
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 15 deletions.
diff --git a/dist/IngoSCostTransparency.zip b/dist/IngoSCostTransparency.zip
diff --git a/...ransparency/src/Resources/app/storefront/src/scss/page/product-detail/product-detail.scss b/...ransparency/src/Resources/app/storefront/src/scss/page/product-detail/product-detail.scss
@@ -62,7 +62,14 @@
     cursor: pointer;
 
     .ingos-cost-group-bar {
-      background-color: silver; /* fallback style */
+      background-color: silver; /* fallback style will be overridden */
+      height: 3rem;
+      border-radius: 0.25rem;
+      box-shadow: 0 0.25rem 0.25rem 0 rgba(0, 0, 0, 0.25);
+    }
+
+    &.ingos-active > .ingos-cost-group-bar {
+      box-shadow: 0 0.5rem 0.5rem 0 rgba(0, 0, 0, 0.5);
     }
 
     .ingos-cost-group-bar-01 {
@@ -141,16 +148,6 @@
       display: -webkit-box;
       -webkit-box-orient: vertical;
     }
-
-    .ingos-cost-group-bar {
-      height: 3rem;
-      border-radius: 0.25rem;
-      box-shadow: 0 0.25rem 0.25rem 0 rgba(0, 0, 0, 0.25);
-    }
-
-    &.ingos-active > .ingos-cost-group-bar {
-      box-shadow: 0 0.5rem 0.5rem 0 rgba(0, 0, 0, 0.5);
-    }
   }
 }
 

diff --git a/.../src/Resources/views/storefront/element/cms-element-product-description-reviews.html.twig b/.../src/Resources/views/storefront/element/cms-element-product-description-reviews.html.twig
@@ -14,8 +14,8 @@
                     class="nav-link product-detail-tab-navigation-link"
                     id="ingos-cost-transparency-tab"
                     data-bs-toggle="tab"
-                    data-off-canvas-tabs="true" {# new attribute name #}
-                    data-offcanvas-tabs="true" {# deprecated attribute name for backward compatibility #}
+                    data-off-canvas-tabs="true" {# new attribute #}
+                    data-offcanvas-tabs="true" {# deprecated attribute for backward compatibility #}
                     href="#ingos-cost-transparency-tab-pane"
                     role="tab"
                     aria-controls="ingos-cost-transparency-tab-pane"

diff --git a/src/IngoSCostTransparency/src/Resources/views/storefront/page/product-detail/tabs.html.twig b/src/IngoSCostTransparency/src/Resources/views/storefront/page/product-detail/tabs.html.twig
@@ -15,8 +15,8 @@
                     class="nav-link product-detail-tab-navigation-link"
                     id="ingos-cost-transparency-tab"
                     data-bs-toggle="tab"
-                    data-off-canvas-tabs="true" {# new attribute name #}
-                    data-offcanvas-tabs="true" {# deprecated attribute name for backward compatibility #}
+                    data-off-canvas-tabs="true" {# new attribute #}
+                    data-offcanvas-tabs="true" {# deprecated attribute for backward compatibility #}
                     href="#ingos-cost-transparency-tab-pane"
                     role="tab"
                     aria-controls="ingos-cost-transparency-tab-pane"