Remove TODOs from the code base, use issue tracker instead #679
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
=========================================
Coverage ? 71.00%
=========================================
Files ? 55
Lines ? 6832
Branches ? 0
=========================================
Hits ? 4851
Misses ? 1981
Partials ? 0 ☔ View full report in Codecov by Sentry. |
| @@ -1621,52 +1618,3 @@ def _ec2_startup_script(self, instance_key, script_params="", timeout_secs=-1): | |||
| if timeout_secs > 0 | |||
| else rconfig().aws.max_timeout_seconds, | |||
| ) | |||
|
|
|||
|
|
|||
| class AWSRemoteBenchmark(Benchmark): | |||
There was a problem hiding this comment.
I think the idea is to create an AWS benchmark which saves results during execution to avoid losing data when a task errors when you run multiple tasks? Not entirely sure what Seb meant. Running multiple tasks is assumed to be sequential (in parallel we can't guarantee fair resource usage), which means also extra cleanup between runs and so on. There hasn't been a request for this in the 6 years since it was written, i'm not 100% sure what is meant, so this is not converted to an issue,
| @@ -136,7 +135,6 @@ def _run(): | |||
| else rconfig().seed, | |||
| ) | |||
| ) | |||
| # TODO: would be nice to reload generated scores and return them | |||
There was a problem hiding this comment.
While that would follow the other job results, results currently get printed and saved to logs fine? So I am not 100% sure what the added value is. Might be missing something, didn't have a close look.
No description provided.