Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test for 3.9, 3.10, 3.11 #1317

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Conversation

eddiebergman
Copy link
Collaborator

This PR adds testing for 3.9-3.12. Some of these may fail due to scikit-learn. Not sure what to do about this since this will eventually be refactored out into its own package

@eddiebergman eddiebergman added the CI About continious integration label Jan 15, 2024
@LennartPurucker
Copy link
Contributor

Let us wait until we decide on the future of the sklearn extension to proceed with this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b22a5e3) 84.21% compared to head (dbfa7bc) 68.76%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1317       +/-   ##
============================================
- Coverage    84.21%   68.76%   -15.46%     
============================================
  Files           38       38               
  Lines         5253     5253               
============================================
- Hits          4424     3612      -812     
- Misses         829     1641      +812     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddiebergman
Copy link
Collaborator Author

Let us wait until we decide on the future of the sklearn extension to proceed with this PR.

Just going to set it up in the meantime

@eddiebergman
Copy link
Collaborator Author

This PR now works. As expected, there's scikit-learn errors with 3.10, 3.11 and 3.12 that still need to be handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI About continious integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants