Update C++ version and minimum macOS version

openmm · May 23, 2024 · 41090bd · 41090bd
1 parent 6f3a150
commit 41090bd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -15,7 +15,7 @@ SET(CMAKE_PREFIX_PATH "${PYTORCH_DIR}")
 FIND_PACKAGE(Torch REQUIRED)
 
 # Specify the C++ version we are building for.
-SET (CMAKE_CXX_STANDARD 14)
+SET (CMAKE_CXX_STANDARD 17)
 
 # Set flags for linking on mac
 IF(APPLE)

diff --git a/python/setup.py b/python/setup.py
@@ -9,12 +9,12 @@
 torch_dir, _ = os.path.split('@TORCH_LIBRARY@')
 
 # setup extra compile and link arguments on Mac
-extra_compile_args = ['-std=c++14']
+extra_compile_args = ['-std=c++17']
 extra_link_args = []
 
 if platform.system() == 'Darwin':
- extra_compile_args += ['-stdlib=libc++', '-mmacosx-version-min=10.7']
- extra_link_args += ['-stdlib=libc++', '-mmacosx-version-min=10.7', '-Wl', '-rpath', openmm_dir+'/lib', '-rpath', torch_dir]
+ extra_compile_args += ['-stdlib=libc++', '-mmacosx-version-min=10.13']
+ extra_link_args += ['-stdlib=libc++', '-mmacosx-version-min=10.13', '-Wl', '-rpath', openmm_dir+'/lib', '-rpath', torch_dir]
 
 extension = Extension(name='_openmmtorch',
  sources=['TorchPluginWrapper.cpp'],