Add damages for crops from methane emissions #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrising
commented
Sep 10, 2024
There was a problem hiding this comment.
@Dennisliu2001 I've added comments to your component. Please take a look.
jrising
commented
Sep 13, 2024
|
@Dennisliu2001 Thanks for adding all the methane calculations. I'm worried though about code duplication. Is the logic for each of the components the same? If so, please either have one component calculate all of the outcomes (do this if the main calculations are the same for all of them) or use one component added multiple times with different inputs (like we do with abatement costs). Also, please add documentation in a separate markdown file or jupyter notebook with information on the logic, sources, and units. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Dennisliu2001 Please fill in a description here.