Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the CR search operation from default #17

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

reagan-meant
Copy link
Collaborator

See ticket here for details
Is there a better way to differentiate these methods?

Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that resorting to using custom operations with the @Operation annotation solves the issue; the other solution would be defining a wrapper object for the Patient class to prevent the override:

// POJO

public class CRPatient {
   // props
}

// Resource Provider

@Component("crPatientFhirR4ResourceProvider")
@R4Provider
@Setter(PACKAGE)
public class FhirCRPatientResourceProvider implements IResourceProvider {
	
	@Override
	public Class<? extends IBaseResource> getResourceType() {
		return CRPatient.class;
	}
	

@reagan-meant
Copy link
Collaborator Author

Merging this as is. Further improvement will be done later

@reagan-meant reagan-meant merged commit 3ee339c into openmrs:main Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants