Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial addition of GitHub actions #10

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Initial addition of GitHub actions #10

merged 7 commits into from
Jan 3, 2024

Conversation

dgkf-roche
Copy link
Collaborator

  • Add basic documentation placeholder
  • Add basic test suite placeholder
  • Adds test, coverage & documentation github actions

I'm not sure how this will all go until an actual package is in place, but this should lay the foundation for these various needs once you get there.

Note you'll need to configure the repo to deploy from the gh-pages branch before it will actually deploy anything.

@dgkf-roche
Copy link
Collaborator Author

Jobs are currently failing because it's looking for src/SafetySignalDetection.jl to load the package. Otherwise I think it should be okay.

ERROR: LoadError: expected the file `src/SafetySignalDetection.jl` to exist for package `SafetySignalDetection` at `/home/runner/work/SafetySignalDetection.jl/SafetySignalDetection.jl`

Once you have a basic module skeleton in place I think it will be okay.

@brockk brockk closed this Nov 30, 2023
@brockk
Copy link
Collaborator

brockk commented Nov 30, 2023

Completing this PR because I completed the other that seemed to be standing in the way of this.

@brockk brockk deleted the dev/cicd branch November 30, 2023 15:50
@danielinteractive
Copy link
Collaborator

I guess we can reopen this - @brockk I think we should get our GH actions in place, right?

@danielinteractive danielinteractive restored the dev/cicd branch December 8, 2023 15:17
@danielinteractive
Copy link
Collaborator

@dgkf-roche Hi Doug, what would be the next steps here?

@dgkf-roche
Copy link
Collaborator Author

@dgkf-roche Hi Doug, what would be the next steps here?

I'll investigate. I've just been able to reproduce it locally with (just copying the relevant lines from the action:

julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path = pwd())); Pkg.instantiate(); include("docs/make.jl")'

I'm splitting my time right now between a few different projects, but I'll see if I can find a quick solution to this snag.

Co-authored-by: dgkf-roche <91694157+dgkf-roche@users.noreply.github.com>
@danielinteractive danielinteractive merged commit 97ba127 into main Jan 3, 2024
2 checks passed
@danielinteractive danielinteractive deleted the dev/cicd branch January 3, 2024 10:00
@danielinteractive danielinteractive mentioned this pull request Jan 3, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants