-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve timeline #152
Open
LDSamson
wants to merge
14
commits into
dev
Choose a base branch
from
ls_improve_timeline
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve timeline #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDSamson
force-pushed
the
ls_improve_timeline
branch
from
January 16, 2025 15:48
737dfcb
to
f57a695
Compare
@jthompson-arcus I've found the issue with the class id and the javascript functions: I could not find the tag because the HTML widget renders late. https://stackoverflow.com/a/62796035/11856430. I will add a few more tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See below for the timeline improvements:
The PR works but it needs some fine tuning. To optimize the improvements, I need to add a custom
js
function to trigger theredraw()
option for the timeline when hovering over an item that has been reviewed, and after clicking on such an item, to get a proper animation in such a case. But I was not yet able to find the right tag for these timeline boxes. Would you able to help with this, @jthompson-arcus ?