Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace matchTolerance with assert_equal #705

Closed
Puzzled-Face opened this issue Oct 12, 2023 · 1 comment · Fixed by #706
Closed

Replace matchTolerance with assert_equal #705

Puzzled-Face opened this issue Oct 12, 2023 · 1 comment · Fixed by #706
Assignees
Labels

Comments

@Puzzled-Face
Copy link
Collaborator

Write an assert_equal checkmate-like function and use it as a replacement for matchTolerance.

See #683 for details.

@Puzzled-Face Puzzled-Face self-assigned this Oct 12, 2023
@Puzzled-Face
Copy link
Collaborator Author

Puzzled-Face commented Oct 13, 2023

The title of this issue is misleading. An assert_equal function is not a replacement for matchTolerance. Given a value (in its first argument), a list/vector (in its second argument) and a tolerance (in its third), matchTolerance selects the (first) match to the value from the vector/list that is within tolerance. It does not confirm that the value(s) in the first argument are all present in the second argument, allowing for given tolerance.

Therefore, it would be better simply to rename matchTolerance to match_within_tolerance.

@Puzzled-Face Puzzled-Face linked a pull request Oct 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant