Refactoring matchTolerance #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: c36809b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
….com:Roche/crmPack into 705-replace-matchtolerance-with-assert_equal
R/checkmate.R
Outdated
| #' | ||
| #' @note If elements in `...` are not all of the same length, `FALSE` is returned. | ||
| #' | ||
| #' @return TRUE if all element-by-element differences are less than `tolerance` |
There was a problem hiding this comment.
Suggested change
| #' @return TRUE if all element-by-element differences are less than `tolerance` | |
| #' @return `TRUE` if all element-by-element differences are less than `tolerance` |
| check_equal <- function(..., tol = sqrt(.Machine$double.eps)) { | ||
| dot_args <- list(...) | ||
|
|
||
| sapply(dot_args, assert_numeric) |
There was a problem hiding this comment.
better use vapply everywhere here (because it is safer)
There was a problem hiding this comment.
better use
vapplyeverywhere here (because it is safer)
vapply is new to me. Not sure I agree here.
The potential problem is vapply's FUN.VALUE argument. From the online doc: "all values of FUN [should be] compatible with the FUN.VALUE, in that they must have the same length and type".
The problem is that we don't know:
- How many entries are in
... - The length of each entry in
...
and, in addition,
assert_numericreturns an object of the same type as its first argument (or throws an error)
I think we could work all that out, but it would add considerably to the complexity of the function.
| #' assert_equal(1:2, 1:2) # no error | ||
| #' assert_equal(0.01, 0.02, tol = 0.05) # no error | ||
| # nolint start | ||
| assert_equal <- function(..., tol = sqrt(.Machine$double.eps), .var.name = vname(x), add = NULL) { |
There was a problem hiding this comment.
better use makeAssertionFunction or add comment why that would not work
There was a problem hiding this comment.
better use
makeAssertionFunctionor add comment why that would not work
assert_equal <- makeAssertionFunction(check_equal) fails with error "Error in checkmate::makeAssertion(..., res, .var.name, add): unused argument (add)". I think this is because of the use of ... in check_equal.
danielinteractive
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #683 and #705 for details