Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring matchTolerance #706
Refactoring matchTolerance #706
Changes from all commits
9c5ab74
9207a92
ebe046f
861281c
daa2081
6c9bf09
c36809b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use
vapply
everywhere here (because it is safer)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vapply
is new to me. Not sure I agree here.The potential problem is
vapply
'sFUN.VALUE
argument. From the online doc: "all values of FUN [should be] compatible with the FUN.VALUE, in that they must have the same length and type".The problem is that we don't know:
...
...
and, in addition,
assert_numeric
returns an object of the same type as its first argument (or throws an error)I think we could work all that out, but it would add considerably to the complexity of the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use
makeAssertionFunction
or add comment why that would not workThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert_equal <- makeAssertionFunction(check_equal)
fails with error "Error incheckmate::makeAssertion(..., res, .var.name, add)
: unused argument (add)". I think this is because of the use of...
incheck_equal
.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.