Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

656 median mtd #661

Closed
wants to merge 26 commits into from
Closed

656 median mtd #661

wants to merge 26 commits into from

Conversation

Prerana17
Copy link
Collaborator

Pull Request

Will be review by @0liver0815 initially.

Fixes ##656

Copy link
Collaborator

@0liver0815 0liver0815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review finished.

R/Design-methods.R Outdated Show resolved Hide resolved
R/Design-methods.R Outdated Show resolved Hide resolved
R/Design-methods.R Outdated Show resolved Hide resolved
R/Design-methods.R Outdated Show resolved Hide resolved
R/Design-methods.R Outdated Show resolved Hide resolved
R/Simulations-class.R Outdated Show resolved Hide resolved
R/Simulations-class.R Show resolved Hide resolved
R/Simulations-methods.R Outdated Show resolved Hide resolved
R/Simulations-methods.R Show resolved Hide resolved
R/Simulations-methods.R Outdated Show resolved Hide resolved
@danielinteractive
Copy link
Collaborator

Hi @Prerana17 is this ready for my review? just let me know and I can do it

Copy link
Collaborator

@0liver0815 0liver0815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes to comments.

R/Design-methods.R Outdated Show resolved Hide resolved
R/Design-methods.R Outdated Show resolved Hide resolved
@0liver0815
Copy link
Collaborator

To resolve the r cmd check error, I think you need to add an empty list to the other simulation methods, as e.g. done for the stopping here: https://github.com/Roche/crmPack/blob/96702347ab8b7cc09c69df80110afbd1b10bdfd6/R/Design-methods.R#L1093
To avoid empty reporting lines, I propose that the results are only printed in summary, when the list is not empty.

@github-actions
Copy link
Contributor

Unit Tests Summary

       1 files       35 suites   2m 19s ⏱️
1 120 tests    993 ✔️ 124 💤 1  2 🔥
5 995 runs  5 834 ✔️ 158 💤 1  2 🔥

For more details on these failures and errors, see this check.

Results for commit d39ac3a.

@Prerana17 Prerana17 closed this Aug 17, 2023
@Prerana17
Copy link
Collaborator Author

Old PR for median and CV MTD

@cicdguy cicdguy deleted the 656_medianMTD branch August 8, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants