-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
656 median mtd #661
656 median mtd #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review finished.
Hi @Prerana17 is this ready for my review? just let me know and I can do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor changes to comments.
To resolve the r cmd check error, I think you need to add an empty list to the other simulation methods, as e.g. done for the stopping here: https://github.com/Roche/crmPack/blob/96702347ab8b7cc09c69df80110afbd1b10bdfd6/R/Design-methods.R#L1093 |
… 656_medianMTD
Old PR for median and CV MTD |
Pull Request
Will be review by @0liver0815 initially.
Fixes ##656