Remove references to is.bool and is.scalar #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: 00b561c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Thanks @Puzzled-Face , see suggestions inside which also apply to other changes
…tions-from-checkmate' of github.com:Roche/crmPack into 685-replace-isscalar-and-isbool-with-corresponding-functions-from-checkmate
danielinteractive
approved these changes
Oct 4, 2023
Puzzled-Face
deleted the
685-replace-isscalar-and-isbool-with-corresponding-functions-from-checkmate
branch
Puzzled-Face
added a commit
that referenced
this pull request
Oct 16, 2023
* Refactor setSeed and getResultList (#676) Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * 675: Add `DesignGrouped` (#677) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fixes first cohort logic for grouped design simulation (#684) * Remove references to is.bool and is.scalar (#686) * Remove references to is.bool and is.scalar * [skip actions] Restyle files * Responding to review comments * Removing lintr moan * Updating documentation --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Remove plot.gtable and print.gtable (#697) * Remove plot.gtable and print.gtable * Fix _pkgdown.yaml * 690 remove safeinteger and iswholenumber 1 (#693) * Remove safeInteger and is.wholenumber * Fixing false test failures * [skip actions] Restyle files --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Remove noOverlap (#695) * remove %~% (#689) * remove %~% * Fixing NAMESPACE * 699 remove multiplot (#700) * Remove multiplot * Correct typo * Correcting typo in argument to assert_integerish * New commit for additional statistics (#663) * New commit for additional statistics * [skip actions] Restyle files * Update: additional statstics added to other designs bug correction suggetions by Clara * bug corrected * Update: Additional_stats * update: additional_stats * updaze: error_corrections (additional_stats) * update: additional_statistics * Dynamic: Additional_statistical_summary * Additional statistical summary function update * additional statistical summary changes * Update: Additional Statistical Summary * small change: additional stat summary * Suggested changes: additional_statistics and validation * [skip actions] Restyle files * Simulation refectoring * Simulation small update * [skip actions] Restyle files * small update * incorrectly named file:delete * removing documentation errors * update yaml file --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Clara <clara.beck@bayer.com> Co-authored-by: Oliver Boix <95433070+0liver0815@users.noreply.github.com> Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com> * Refactor myBarplot (#703) * Refactor myBarplot * [skip actions] Restyle files * Responding to lintr complaints * Rsponding to review comments --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Oliver Boix <95433070+0liver0815@users.noreply.github.com> Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Prerana Chandratre <82475780+Prerana17@users.noreply.github.com> Co-authored-by: Clara <clara.beck@bayer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #nnn