-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
683 replace/remove is.probability/is.range/is.prob range with applicable additional checkmate assertions #692
Conversation
…onal checkmate assertions
…t_probability from additional checkmate assertions
…_additional_checkmate_assertions
Code Coverage Summary
Diff against main
Results for commit: 314e350 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dimitriskontosBAY , please see below
…oid the stopifnot
…s.probRange_with_applicable_additional_checkmate_assertions
…s.probRange_with_applicable_additional_checkmate_assertions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there!
…s.probRange_with_applicable_additional_checkmate_assertions
@@ -87,7 +89,6 @@ Quantiles2LogisticNormal <- function(dosegrid, | |||
identical(length(upper), nDoses), | |||
all(lower < median), | |||
all(upper > median), | |||
is.probability(level, bounds = FALSE), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here used assert_probability and avoid stopifnot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @dimitriskontosBAY !
Pull Request
Addresses the following taks from #683