Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

690 remove safeinteger and iswholenumber 1 #693

Merged
merged 5 commits into from
Oct 10, 2023
Merged

690 remove safeinteger and iswholenumber 1 #693

merged 5 commits into from
Oct 10, 2023

Conversation

Puzzled-Face
Copy link
Collaborator

See #690 for details

@Puzzled-Face Puzzled-Face linked an issue Oct 9, 2023 that may be closed by this pull request
Remove safeInteger and is.wholenumber #690
Closed
@Puzzled-Face Puzzled-Face mentioned this pull request Oct 9, 2023
Closed
16 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                  49       0  100.00%
R/crmPack-package.R             4       0  100.00%
R/Data-class.R                 91       4  95.60%   466-467, 473-478
R/Data-methods.R              203       0  100.00%
R/Data-validity.R             144       1  99.31%   21
R/Design-class.R               75       0  100.00%
R/Design-methods.R           2734    2310  15.51%   108, 133-136, 144-155, 159-178, 190-194, 200-213, 372-928, 993-1334, 1385, 1575, 1746-4528, 4647
R/Design-validity.R            20       0  100.00%
R/fromQuantiles.R             178      69  61.24%   237-378
R/helpers_covr.R               23       0  100.00%
R/helpers_data.R               84       1  98.81%   139
R/helpers_design.R             75      36  52.00%   22, 77-129
R/helpers_jags.R               77       0  100.00%
R/helpers_model.R              78       4  94.87%   38, 89-90, 139
R/helpers_rules.R             447       0  100.00%
R/helpers.R                   259      95  63.32%   103-118, 131, 144-158, 194-371, 401-450
R/logger.R                     11       0  100.00%
R/mcmc.R                      287      18  93.73%   90-95, 374-375, 385, 387-388, 391-394, 577-578, 667, 673, 731
R/McmcOptions-class.R          18       0  100.00%
R/McmcOptions-methods.R         8       1  87.50%   43
R/McmcOptions-validity.R       42       0  100.00%
R/Model-class.R               962     155  83.89%   135-137, 205-207, 211-213, 272-274, 346-348, 352-354, 433-435, 502-504, 566-570, 573-576, 679-682, 686-687, 802-806, 926-928, 932-940, 1085-1087, 1092-1095, 1099-1102, 1218-1222, 1224-1227, 1231-1234, 1237, 1398-1408, 1413-1419, 1574-1577, 1583-1590, 1747, 1756, 1765, 1774, 1783-1788, 1924, 1933, 1942, 1950-1952, 2693-2722, 2726-2732, 2739-2743, 2748, 2855-2868, 2894, 2990-2992, 2996, 3089-3091, 3095, 3164-3176, 3194
R/Model-methods.R             376      34  90.96%   78, 155, 208, 675-720, 1039-1048
R/Model-validity.R            435       8  98.16%   430-433, 442-445
R/ModelParams-class.R          13       0  100.00%
R/ModelParams-validity.R       21       0  100.00%
R/Rules-class.R               416       2  99.52%   3098, 3165
R/Rules-methods.R            1429     164  88.52%   741, 744, 887, 890, 893, 1008, 1011, 1014, 1134-1137, 1171, 1274-1277, 1312, 2475-2483, 2507-2514, 3017-3260
R/Rules-validity.R            418       0  100.00%
R/Samples-class.R               1       0  100.00%
R/Samples-methods.R          1104      45  95.92%   406-416, 644, 1358-1393, 1616, 1629, 1794, 2124-2129
R/Samples-validity.R           10       0  100.00%
R/Simulations-class.R          50      32  36.00%   471-820
R/Simulations-methods.R      1597    1454  8.95%    65-350, 406, 416-435, 448-453, 500-509, 675-2935
R/utils.R                       6       0  100.00%
TOTAL                       11745    4433  62.26%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/Data-class.R             +11       0  +0.60%
R/Data-methods.R            +1       0  +100.00%
R/Design-methods.R          -8      -7  +0.01%
R/helpers.R                -10      -6  +0.87%
R/Model-class.R             +2       0  +0.03%
R/Rules-class.R            +24       0  +0.03%
R/Simulations-class.R       +1       0  +1.31%
TOTAL                      +21     -13  +0.18%

Results for commit: cb176f2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

danielinteractive
danielinteractive approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Puzzled-Face !

@Puzzled-Face Puzzled-Face enabled auto-merge (squash) October 10, 2023 07:58
@github-actions
Copy link
Contributor

Unit Tests Summary

       1 files       36 suites   2m 20s ⏱️
1 173 tests 1 045 ✔️ 128 💤 0 ❌
6 190 runs  6 027 ✔️ 163 💤 0 ❌

Results for commit cb176f2.

@Puzzled-Face Puzzled-Face merged commit b6cdd56 into main Oct 10, 2023
20 checks passed
@Puzzled-Face Puzzled-Face deleted the 690-remove-safeinteger-and-iswholenumber-1 branch October 10, 2023 08:44
@Puzzled-Face Puzzled-Face mentioned this pull request Oct 10, 2023
Merged
Puzzled-Face added a commit that referenced this pull request Oct 16, 2023
@Puzzled-Face @0liver0815
@danielinteractive @github-actions @Prerana17 @ClaraBeckBayer
Implement the LogisticLogNormalOrdinal class (#708)
8a243c1 
* Refactor setSeed and getResultList (#676)

Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* 675: Add `DesignGrouped` (#677)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Fixes first cohort logic for grouped design simulation (#684)

* Remove references to is.bool and is.scalar (#686)

* Remove references to is.bool and is.scalar

* [skip actions] Restyle files

* Responding to review comments

* Removing lintr moan

* Updating documentation

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Remove plot.gtable and print.gtable (#697)

* Remove plot.gtable and print.gtable

* Fix _pkgdown.yaml

* 690 remove safeinteger and iswholenumber 1 (#693)

* Remove safeInteger and is.wholenumber

* Fixing false test failures

* [skip actions] Restyle files

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Remove noOverlap (#695)

* remove %~% (#689)

* remove %~%

* Fixing NAMESPACE

* 699 remove multiplot (#700)

* Remove multiplot

* Correct typo

* Correcting typo in argument to assert_integerish

* New commit for additional statistics (#663)

* New commit for additional statistics

* [skip actions] Restyle files

* Update: additional statstics added to other designs bug correction suggetions by Clara

* bug corrected

* Update: Additional_stats

* update: additional_stats

* updaze: error_corrections (additional_stats)

* update: additional_statistics

* Dynamic: Additional_statistical_summary

* Additional statistical summary function update

* additional statistical summary changes

* Update: Additional Statistical Summary

* small change: additional stat summary

* Suggested changes: additional_statistics and validation

* [skip actions] Restyle files

* Simulation refectoring

* Simulation small update

* [skip actions] Restyle files

* small update

* incorrectly named file:delete

* removing documentation errors

* update yaml file

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Clara <clara.beck@bayer.com>
Co-authored-by: Oliver Boix <95433070+0liver0815@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>

* Refactor myBarplot (#703)

* Refactor myBarplot

* [skip actions] Restyle files

* Responding to lintr complaints

* Rsponding to review comments

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Oliver Boix <95433070+0liver0815@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Prerana Chandratre <82475780+Prerana17@users.noreply.github.com>
Co-authored-by: Clara <clara.beck@bayer.com>
@Puzzled-Face Puzzled-Face mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove safeInteger and is.wholenumber
2 participants
@Puzzled-Face @danielinteractive