add feature needed to stop mono arm when combo arm stops

[danielinteractive]

No description provided.

[github-actions]

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                  73       1  98.63%   72
R/crmPack-package.R             4       0  100.00%
R/Data-class.R                147       5  96.60%   43, 564-565, 571-576
R/Data-methods.R              203       0  100.00%
R/Data-validity.R             144       1  99.31%   21
R/Design-class.R              320       0  100.00%
R/Design-methods.R           2779    1874  32.57%   111, 136-139, 147-158, 162-181, 193-197, 203-216, 392-516, 659-663, 687-690, 698-717, 722-751, 755-756, 758, 773-781, 785, 797-816, 1034-1375, 1426, 1616, 1787-3971, 4069, 4071-4072, 4131, 4167, 4204-4207, 4226-4230, 4291-4298, 4326-4330, 4338-4356, 4382-4401, 4404, 4437, 4459-4477, 4711
R/Design-validity.R            24       0  100.00%
R/fromQuantiles.R             178      69  61.24%   237-378
R/helpers_covr.R               23       0  100.00%
R/helpers_data.R               84       1  98.81%   139
R/helpers_design.R             75      35  53.33%   77-129
R/helpers_jags.R               77       0  100.00%
R/helpers_model.R              78       4  94.87%   38, 89-90, 139
R/helpers_rules.R             428       0  100.00%
R/helpers_simulations.R        18       0  100.00%
R/helpers.R                   229      65  71.62%   107-127, 140, 153-167, 203-323, 358-372
R/logger.R                     11       0  100.00%
R/mcmc.R                      287      18  93.73%   90-95, 374-375, 385, 387-388, 391-394, 577-578, 667, 673, 731
R/McmcOptions-class.R          22       0  100.00%
R/McmcOptions-methods.R         8       1  87.50%   43
R/McmcOptions-validity.R       42       0  100.00%
R/Model-class.R              1012     155  84.68%   145-147, 216-218, 222-224, 283-285, 357-359, 363-365, 444-446, 513-515, 577-581, 584-587, 690-693, 697-698, 813-817, 937-939, 943-951, 1096-1098, 1103-1106, 1110-1113, 1229-1233, 1235-1238, 1242-1245, 1248, 1409-1419, 1424-1430, 1585-1588, 1594-1601, 1758, 1767, 1776, 1785, 1794-1799, 1935, 1944, 1953, 1961-1963, 2807-2836, 2840-2846, 2853-2857, 2862, 2969-2982, 3008, 3104-3106, 3110, 3203-3205, 3209, 3278-3290, 3308
R/Model-methods.R             376      34  90.96%   78, 155, 208, 675-720, 1039-1048
R/Model-validity.R            435       8  98.16%   430-433, 442-445
R/ModelParams-class.R          17       0  100.00%
R/ModelParams-validity.R       21       0  100.00%
R/Rules-class.R               431       2  99.54%   3150, 3231
R/Rules-methods.R            1429     164  88.52%   741, 744, 887, 890, 893, 1008, 1011, 1014, 1134-1137, 1171, 1274-1277, 1312, 2475-2483, 2507-2514, 3017-3260
R/Rules-validity.R            418       0  100.00%
R/Samples-class.R               6       0  100.00%
R/Samples-methods.R          1104      45  95.92%   406-416, 644, 1358-1393, 1616, 1629, 1794, 2124-2129
R/Samples-validity.R           10       0  100.00%
R/Simulations-class.R         190      28  85.26%   601-613, 708-718, 770-773
R/Simulations-methods.R      1604    1460  8.98%    65-350, 406, 416-435, 448-453, 500-509, 675-2944
R/Simulations-validity.R       75      75  0.00%    20-168
R/utils.R                       6       0  100.00%
TOTAL                       12388    4045  67.35%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/Design-class.R          +1       0  +100.00%
R/Design-methods.R       +16       0  +0.39%
R/Design-validity.R       +4       0  +100.00%
TOTAL                    +21       0  +0.06%

Results for commit: dcfe11a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

       1 files       37 suites   3m 26s ⏱️
1 181 tests 1 051 ✔️ 130 💤 0 ❌
6 233 runs  6 068 ✔️ 165 💤 0 ❌

Results for commit dcfe11a.

♻️ This comment has been updated with latest results.

[Puzzled-Face]

FYI

Examples with CPU (user + system) or elapsed time > 5s
                                             user system elapsed
 simulate-DesignGrouped-method             33.515  0.394  33.585
 summary-PseudoDualSimulations-method       9.448  1.375   9.297
 show-PseudoDualSimulationsSummary-method   9.325  1.407   9.187

The simulate-DesignGrouped-method example is the longest running of all examples, by factor of more than 3. Can its run time be reduced?

Perhaps change nsim = 4 to nsim = 2 or nsim = 1?

[danielinteractive]

Thanks @Puzzled-Face - one question, when running through the example I noticed that the lines

plot(mono_sims_sum)
plot(combo_sims_sum)

no longer produce the plots as before - could that be due to the removed multiplot thing? would you mind having a look?

[Puzzled-Face]

Thanks @Puzzled-Face - one question, when running through the example I noticed that the lines

plot(mono_sims_sum)
plot(combo_sims_sum)

no longer produce the plots as before - could that be due to the removed multiplot thing? would you mind having a look?

I missed this. Apologies. Will take a look.