Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.9.1 to 2.21.2 #1579

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2023

Bumps rubocop-rails from 2.9.1 to 2.21.2.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.21.2

Bug fixes

  • #1126: Fix a false positive for Rails/RedundantActiveRecordAllMethod when using some Enumerable's methods with block argument. (@​koic)
  • #1121: Fix an error for Rails/SelectMap when using select(:column_name).map(&:column_name) without receiver model. (@​koic)
  • #1119: Fix an incorrect autocorrect for Rails/RedundantActiveRecordAllMethod when all has parentheses. (@​masato-bkn)
  • #1130: Fix crash for Rails/UniqueValidationWithoutIndex with bare validate. (@​jamiemccarthy)
  • #1124: Fix false positives for Rails/RedundantActiveRecordAllMethod when receiver is not an Active Record model. (@​koic)

RuboCop Rails 2.21.1

Bug fixes

  • #1108: Fix an incorrect autocorrect for Rails/TimeZone when using String#to_time. (@​koic)
  • #1109: Fix error for Rails/RedundantActiveRecordAllMethod when all is an argument for AR methods. (@​masato-bkn)
  • #1110: Fix false positive for Rails/RedundantActiveRecordAllMethod when all has any parameters. (@​masato-bkn)

RuboCop Rails 2.21.0

New features

  • #1075: Add new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). (@​koic)
  • #158: Add Rails/DangerousColumnNames cop. ([@​r7kamura][])
  • #1072: Add TransactionMethods config for Rails/TransactionExitStatement to detect custom transaction methods. ([@​marocchino][])
  • #967: Add new Rails/UnusedRenderContent cop. ([@​samrjenkins][])
  • #1052: Add explicit style to Rails/I18nLazyLookup. ([@​sunny][])
  • #1016: Add new Rails/RedundantActiveRecordAllMethod cop. (@​masato-bkn)

Bug fixes

  • #1078: Fix a false negative for Rails/LexicallyScopedActionFilter when no methods are defined. ([@​vlad-pisanov][])
  • #1060: Fix a false positive for Rails/HttpStatus when using symbolic value that have no numeric value mapping. (@​koic)
  • #1004: Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower. ([@​r7kamura][])
  • #1066: Fix an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with .. (@​koic)
  • #1049: Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /. ([@​ydah][])
  • #1045: Fix an incorrect autocorrect for Rails/NegateInclude when using Style/InverseMethods's autocorrection together. (@​koic)
  • #1062: Fix autocorrection for Rails/RakeEnvironment when rake task accepts arguments. ([@​fastjames][])
  • #1036: Fix an error for UniqueValidationWithoutIndex when db/schema.rb is empty. ([@​fatkodima][])
  • #1042: Fix no offences for Rails/SchemaComment when create_table with multi t columns. ([@​nipe0324][])

Changes

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.21.2 (2023-09-30)

Bug fixes

  • #1126: Fix a false positive for Rails/RedundantActiveRecordAllMethod when using some Enumerable's methods with block argument. ([@​koic][])
  • #1121: Fix an error for Rails/SelectMap when using select(:column_name).map(&:column_name) without receiver model. ([@​koic][])
  • #1119: Fix an incorrect autocorrect for Rails/RedundantActiveRecordAllMethod when all has parentheses. ([@​masato-bkn][])
  • #1130: Fix crash for Rails/UniqueValidationWithoutIndex with bare validate. ([@​jamiemccarthy][])
  • #1124: Fix false positives for Rails/RedundantActiveRecordAllMethod when receiver is not an Active Record model. ([@​koic][])

2.21.1 (2023-09-14)

Bug fixes

  • #1108: Fix an incorrect autocorrect for Rails/TimeZone when using String#to_time. ([@​koic][])
  • #1109: Fix error for Rails/RedundantActiveRecordAllMethod when all is an argument for AR methods. ([@​masato-bkn][])
  • #1110: Fix false positive for Rails/RedundantActiveRecordAllMethod when all has any parameters. ([@​masato-bkn][])

2.21.0 (2023-09-09)

New features

  • #1075: Add new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). ([@​koic][])
  • #158: Add Rails/DangerousColumnNames cop. ([@​r7kamura][])
  • #1072: Add TransactionMethods config for Rails/TransactionExitStatement to detect custom transaction methods. ([@​marocchino][])
  • #967: Add new Rails/UnusedRenderContent cop. ([@​samrjenkins][])
  • #1052: Add explicit style to Rails/I18nLazyLookup. ([@​sunny][])
  • #1016: Add new Rails/RedundantActiveRecordAllMethod cop. ([@​masato-bkn][])

Bug fixes

  • #1078: Fix a false negative for Rails/LexicallyScopedActionFilter when no methods are defined. ([@​vlad-pisanov][])
  • #1060: Fix a false positive for Rails/HttpStatus when using symbolic value that have no numeric value mapping. ([@​koic][])
  • #1004: Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower. ([@​r7kamura][])
  • #1066: Fix an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with .. ([@​koic][])
  • #1049: Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /. ([@​ydah][])
  • #1045: Fix an incorrect autocorrect for Rails/NegateInclude when using Style/InverseMethods's autocorrection together. ([@​koic][])
  • #1062: Fix autocorrection for Rails/RakeEnvironment when rake task accepts arguments. ([@​fastjames][])
  • #1036: Fix an error for UniqueValidationWithoutIndex when db/schema.rb is empty. ([@​fatkodima][])
  • #1042: Fix no offences for Rails/SchemaComment when create_table with multi t columns. ([@​nipe0324][])

Changes

  • #1056: Fix database adapter detection for nested config. ([@​mjankowski][])
  • #1031: Make Lint/SafeNavigationChain allow presence_in. ([@​koic][])
  • #1080: Make Rails/HttpStatus aware of string number status. ([@​r7kamura][])
  • #1094: Make Rails/TimeZone aware of String#to_time. ([@​koic][])
  • #1015: Make Style/InvertibleUnlessCondition aware of Active Support methods. ([@​koic][])
  • #903: Read database config for Rails/BulkChangeTable from environment variable. ([@​joergschiller][])
  • #1058: Relax Include path for Rails/FindBy and Rails/FindEach. ([@​koic][])

... (truncated)

Commits
  • fda7a43 Cut 2.21.2
  • c0d83ee Update Changelog
  • 8d63d0e Merge pull request #1135 from technicalpickles/qualify-struct
  • a21f4a3 Use ::Struct to avoid collisions with cop namespace
  • e1b1fff Merge pull request #1126 from koic/fix_a_false_positive_for_rails_redundant_a...
  • e586f7f Fix a false positive for Rails/RedundantActiveRecordAllMethod
  • 0a57811 Merge pull request #1127 from koic/fix_false_positive_for_rails_redundant_act...
  • 7a0208b Merge pull request #1131 from jamiemccarthy/jm-unique-validation-fix
  • bd4f92b [Fix #1130] Fix crash for Rails/UniqueValidationWithoutIndex with bare validate
  • d3117ff Merge pull request #1122 from koic/fix_an_error_for_rails_select_map
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @Floppy.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.9.1 to 2.21.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.9.1...v2.21.2)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Member

@Floppy Floppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 2, 2023

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 27, 2023

Superseded by #1580.

@dependabot dependabot bot closed this Oct 27, 2023
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-rails-2.21.2 branch October 27, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant