Accept None as input argument in barrier and delay #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjaskula-aws
changed the title
jcjaskula-aws
force-pushed
the
jcjaskula-aws/change_barrier_behavior
branch
from
c3aa63a
to
b616186
Compare
jcjaskula-aws
force-pushed
the
jcjaskula-aws/change_barrier_behavior
branch
from
eec93ee
to
a53b3ca
Compare
|
Oops very long review 🙈 Looks good to me, let's just rebase for conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the case where None is supplied as input argument, which adds a delay or a barrier on all frames. This becomes the new default behavior
Closes #15