-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing sweep names and making open_nexradlevel2_datatree
5x faster
#240
Conversation
open_nexradlevel2_tree
5x faster
open_nexradlevel2_tree
5x fasteropen_nexradlevel2_datatree
5x faster
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 93.52% 93.07% -0.45%
==========================================
Files 26 26
Lines 5004 5028 +24
==========================================
Hits 4680 4680
- Misses 324 348 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aladinor Sorry, I've missed the meeting today. Great work! If you can get the Nexrad notebook to work this will be ready to go!
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Docs failing, but this seems like a broader issue. xarray docs failing the same way.
I'm thinking that either GitHub changed something on their policy or some dependency in the network stack runs havoc. If there is someone out there brave enough to hunt that one down... |
Amazing! @aladinor 💯 |
This is awesome! Thanks @aladinor 👍 |
Details: readthedocs/readthedocs.org#11763 This is resolved by openradar/open-radar-data#70 and https://github.com/openradar/open-radar-data/releases/tag/v0.4.0. A bit hacky, but only one source to change. 😁 |
…penradar#240) * fixing sweep names and making open_nexradlevel2 5x faster * using NodePath to ensure 'sweep' parameter * adding test for sweeps argument * removing unnecesary tests * documenting changes in history.md * fixing sweep number
Fixing names when passing sweep to
open_nexradlevel2_tree
and making it 5x faster by caching the file while extracting all datasetshistory.md