Skip to content

Commit

Permalink
[workspace]fix: Change some of the http link in settings page to http…
Browse files Browse the repository at this point in the history
…s link (#8919) (#8987)

* page_references_insecure



* typo



* Changeset file for PR #8919 created/updated

* add https://numeraljs.com/ to lycheeignore



* change https://numeraljs.com/ to http



---------



(cherry picked from commit 4dac5a7)

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Nov 29, 2024
1 parent b4b5d1a commit 573ca63
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/8919.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Change some of the http link in settings page to https link ([#8919](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8919))
2 changes: 1 addition & 1 deletion src/core/server/ui_settings/settings/date_formats.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export const getDateFormatSettings = (): Record<string, UiSettingsParams> => {
'core.ui_settings.params.dateFormat.scaled.intervalsLinkText',
values: {
intervalsLink:
'<a href="http://en.wikipedia.org/wiki/ISO_8601#Time_intervals" target="_blank" rel="noopener noreferrer">' +
'<a href="https://en.wikipedia.org/wiki/ISO_8601#Time_intervals" target="_blank" rel="noopener noreferrer">' +
i18n.translate('core.ui_settings.params.dateFormat.scaled.intervalsLinkText', {
defaultMessage: 'ISO8601 intervals',
}) +
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/maps_legacy/server/ui_settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function getUiSettings(): Record<string, UiSettingsParams<unknown>> {
'maps_legacy.advancedSettings.visualization.tileMap.wmsDefaults.propertiesLinkText',
values: {
propertiesLink:
'<a href="http://leafletjs.com/reference.html#tilelayer-wms" target="_blank" rel="noopener noreferrer">' +
'<a href="https://leafletjs.com/reference.html#tilelayer-wms" target="_blank" rel="noopener noreferrer">' +
i18n.translate(
'maps_legacy.advancedSettings.visualization.tileMap.wmsDefaults.propertiesLinkText',
{
Expand Down

0 comments on commit 573ca63

Please sign in to comment.