fix to get correct getSavedQueryCount

[riysaxen-amzn]

Description

• For getSavedQueryCount the page size is 0 but is not 0 for findSavedQueries since its paginated. This API in Neo returns 0 but the actual count in OSS. This PR will fix the discrepancy

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 8808.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.78%. Comparing base (758e4fb) to head (4e0d7c9).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8808   +/-   ##
=======================================
  Coverage   60.78%   60.78%           
=======================================
  Files        3798     3798           
  Lines       90701    90701           
  Branches    14284    14284           
=======================================
  Hits        55133    55133           
  Misses      32068    32068           
  Partials     3500     3500           

Flag	Coverage Δ
Linux_1	29.05% <ø> (ø)
Linux_2	56.39% <ø> (ø)
Linux_3	37.65% <ø> (+<0.01%)	⬆️
Linux_4	29.82% <ø> (ø)
Windows_1	29.06% <ø> (ø)
Windows_2	56.34% <ø> (ø)
Windows_3	37.65% <ø> (ø)
Windows_4	29.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[virajsanghvi]

Unit tests need to be updated for this to be merged

[riysaxen-amzn]

Unit tests need to be updated for this to be merged

added UTs

 yarn test:jest src/plugins/data/public/query/saved_query/saved_query_service.test.ts
yarn run v1.22.22
$ scripts/use_node scripts/jest src/plugins/data/public/query/saved_query/saved_query_service.test.ts
jest-haste-map: duplicate manual mock found: index
  The following files share their name; please delete one of them:
    * <rootDir>/src/plugins/vis_type_vega/public/expressions/__mocks__/index.ts
    * <rootDir>/src/core/server/saved_objects/import/__mocks__/index.ts

 PASS  src/plugins/data/public/query/saved_query/saved_query_service.test.ts (6.265 s)
  saved query service
    saveQuery
      ✓ should create a saved object for the given attributes (3 ms)
      ✓ should allow overwriting an existing saved query (1 ms)
      ✓ should optionally accept filters and timefilters in object format (1 ms)
      ✓ should throw an error when saved objects client returns error
      ✓ should throw an error if the saved query does not have a title
    findSavedQueries
      ✓ should find and return saved queries without search text or pagination parameters
      ✓ should return the total count along with the requested queries
      ✓ should find and return saved queries with search text matching the title field
      ✓ should find and return parsed filters and timefilters items
      ✓ should return an array of saved queries (1 ms)
      ✓ should accept perPage and page properties
      ✓ should correctly parse a json query string (1 ms)
      ✓ should correctly parse a json object
      ✓ should handle null string with single quote
      ✓ should handle null string with double quote (1 ms)
      ✓ should handle null quoted string
      ✓ should not lose double quotes
    getSavedQuery
      ✓ should retrieve a saved query by id
      ✓ should only return saved queries
    deleteSavedQuery
      ✓ should delete the saved query for the given ID
    getAllSavedQueries
      ✓ should return all the saved queries
    getSavedQueryCount
      ✓ should return the total number of saved queries

Test Suites: 1 passed, 1 total
Tests:       22 passed, 22 total
Snapshots:   0 total
Time:        7.154 s, estimated 11 s
Ran all test suites matching /src\/plugins\/data\/public\/query\/saved_query\/saved_query_service.test.ts/i.
✨  Done in 13.18s.
riysaxen@3c22fbbc0960 OpenSearch-Dashboards % git status

[ashwin-pc]

CIGroup 10 has no tests yet so we can skip it. Merging