[Workspace] Add unit tests for inspect page url #8834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
reviewed
Nov 8, 2024
SuZhou-Joe
reviewed
Nov 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8834 +/- ##
=======================================
Coverage 60.86% 60.87%
=======================================
Files 3799 3800 +1
Lines 90761 90797 +36
Branches 14294 14305 +11
=======================================
+ Hits 55246 55276 +30
- Misses 32005 32007 +2
- Partials 3510 3514 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
reviewed
Nov 11, 2024
...x_pattern_management/public/components/edit_index_pattern/index_header/index_header.test.tsx
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Nov 11, 2024
SuZhou-Joe
previously approved these changes
Nov 11, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
Hailong-am
approved these changes
Nov 11, 2024
ruanyl
approved these changes
Nov 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Add unit tests for inspect page url Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #8834 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 76cf823) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Add unit tests for inspect page url * Changeset file for PR #8834 created/updated * optimize the code * optimize the code * optimize the code --------- (cherry picked from commit 76cf823) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for inspect page url (#8718)
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration