-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] PPL table name parser fix #8843
[Autocomplete] PPL table name parser fix #8843
Conversation
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
src/plugins/data/public/antlr/opensearch_ppl/grammar/OpenSearchPPLParser.g4
Show resolved
Hide resolved
there are some issues with CI right now |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 0f899df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8843 +/- ##
==========================================
- Coverage 60.87% 60.85% -0.02%
==========================================
Files 3799 3799
Lines 90762 90783 +21
Branches 14292 14294 +2
==========================================
+ Hits 55247 55249 +2
- Misses 32005 32025 +20
+ Partials 3510 3509 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
(cherry picked from commit 0f899df) Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Every file under
.generated
can be ignoredThere were two changes made.
Ultimately, this helps to solve an issue where correctly formatted table names (with backticks, etc.) prevented other suggestions from appearing. The original grammar would've parsed it correctly.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration