-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexed view using DATA_STRUCTURE and fetch #8845
base: main
Are you sure you want to change the base?
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8845 +/- ##
==========================================
- Coverage 60.86% 56.39% -4.48%
==========================================
Files 3800 1239 -2561
Lines 90818 25913 -64905
Branches 14307 4437 -9870
==========================================
- Hits 55276 14613 -40663
+ Misses 32028 10559 -21469
+ Partials 3514 741 -2773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the `DATA_STRUCTURE` generic object can handle this concept of indexed view. Here I'm defining DATASET object. If the data type wants to handled the DATASET type and return an indexed view then it can. Added a mock of S3 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
be59172
to
80d028b
Compare
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
1 similar comment
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Description
Very rough implementation of indexed view using the
DATA_STRUCTURE
generic object can handle this concept of indexed view.I didn't do any clean up and it has mocked data of S3 . So i can summarize the basic changes.
Here I'm defining DATASET object. If the data type can supported Indexed Views, it will call a fetch with that current dataset. It can then know it is time to fetch my indexed views. If the user selects an index view then it will update the dataset with the indexed view but store a ref to the original data.
This way we are leveraging existing features since we should have everything we need at the point of time of selection.
Benefits
supports
vs checking if a service is defined on the configIssues Resolved
#8851
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration