Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable filter for s3 #8911

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Reenable filter for s3 #8911

merged 1 commit into from
Nov 21, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Nov 21, 2024

Description

Reenable filter for s3

Issues Resolved

na

Screenshot

na

Testing the changes

na

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Nov 21, 2024
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming it'll pass ci as it did previously

@ananzh ananzh merged commit 89265b6 into opensearch-project:main Nov 21, 2024
57 of 58 checks passed
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (0ec00b1) to head (3fee56d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8911   +/-   ##
=======================================
  Coverage   60.87%   60.87%           
=======================================
  Files        3802     3802           
  Lines       91057    91060    +3     
  Branches    14369    14370    +1     
=======================================
+ Hits        55434    55437    +3     
  Misses      32084    32084           
  Partials     3539     3539           
Flag Coverage Δ
Linux_1 29.01% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.90% <ø> (ø)
Linux_4 29.00% <100.00%> (+<0.01%) ⬆️
Windows_1 29.03% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <ø> (ø)
Windows_4 29.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants