-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace]fix: Change some of the http link in settings page to https link #8919
base: main
Are you sure you want to change the base?
[workspace]fix: Change some of the http link in settings page to https link #8919
Conversation
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
looks like changed to https will leads link check failure
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8919 +/- ##
=======================================
Coverage 60.87% 60.88%
=======================================
Files 3802 3802
Lines 91060 91072 +12
Branches 14370 14375 +5
=======================================
+ Hits 55435 55446 +11
Misses 32085 32085
- Partials 3540 3541 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@Hailong-am Thanks for the comment, the security configuration of Numeral.js may have issues, as it displays insecure warnings regardless of whether HTTP or HTTPS is used. Is there any effective way to address this? |
you can add it to file |
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Thank you! updated |
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Description
This pr changes some of the http link in settings page to https link.
And the affected links are:
https://leafletjs.com
https://en.wikipedia.org/wiki/ISO_8601#Time_intervals
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration