Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace]fix: Change some of the http link in settings page to https link #8919

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Nov 25, 2024

Description

This pr changes some of the http link in settings page to https link.
And the affected links are:

  1. https://leafletjs.com

  2. https://en.wikipedia.org/wiki/ISO_8601#Time_intervals

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: Change some of the http link in settings page to https link

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
ruanyl
ruanyl previously approved these changes Nov 25, 2024
@Hailong-am
Copy link
Collaborator

looks like changed to https will leads link check failure

* [ERR] [https://numeraljs.com/](https://numeraljs.com/) | Failed: Network error: error sending request for url (https://numeraljs.com/)

### Errors in src/plugins/vis_type_timeseries/public/application/components/data_format_picker.js

* [ERR] [https://numeraljs.com/#format](https://numeraljs.com/#format) | Failed: Network error: error sending request for url (https://numeraljs.com/#format)

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.88%. Comparing base (89265b6) to head (079358d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8919   +/-   ##
=======================================
  Coverage   60.87%   60.88%           
=======================================
  Files        3802     3802           
  Lines       91060    91072   +12     
  Branches    14370    14375    +5     
=======================================
+ Hits        55435    55446   +11     
  Misses      32085    32085           
- Partials     3540     3541    +1     
Flag Coverage Δ
Linux_1 29.02% <ø> (+<0.01%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.90% <ø> (?)
Linux_4 29.00% <ø> (-0.01%) ⬇️
Windows_1 29.03% <ø> (+<0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <ø> (-0.01%) ⬇️
Windows_4 29.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qxisylolo
Copy link
Contributor Author

@Hailong-am Thanks for the comment, the security configuration of Numeral.js may have issues, as it displays insecure warnings regardless of whether HTTP or HTTPS is used. Is there any effective way to address this?

@Hailong-am
Copy link
Collaborator

@Hailong-am Thanks for the comment, the security configuration of Numeral.js may have issues, as it displays insecure warnings regardless of whether HTTP or HTTPS is used. Is there any effective way to address this?

you can add it to file .lycheeignore to ignore the check

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
Copy link
Contributor Author

@Hailong-am Thanks for the comment, the security configuration of Numeral.js may have issues, as it displays insecure warnings regardless of whether HTTP or HTTPS is used. Is there any effective way to address this?

you can add it to file .lycheeignore to ignore the check

Thank you! updated

Hailong-am
Hailong-am previously approved these changes Nov 25, 2024
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants