Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove head 10 for PPL default query to unblock cypress test #8922

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

Revert "Remove head 10 for PPL default query to unblock cypress test #8922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8684524
Revert "Remove `head 10` for PPL default query to unblock cypress tes…
abbyhu2000 Nov 25, 2024
3531a37
Changeset file for PR #8922 created/updated
opensearch-changeset-bot[bot] Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions changelogs/fragments/8827.yml
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions changelogs/fragments/8922.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Revert remove head 10 commit ([#8922](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8922))
2 changes: 1 addition & 1 deletion src/plugins/query_enhancements/public/datasets/s3_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const s3TypeConfig: DatasetTypeConfig = {
title: i18n.translate('queryEnhancements.s3Type.sampleQuery.basicPPLQuery', {
defaultMessage: 'Sample query for PPL',
}),
query: `source = ${dataset.title}`,
query: `source = ${dataset.title} | head 10`,
},
];
case 'SQL':
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/query_enhancements/public/plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class QueryEnhancementsPlugin
startServices: core.getStartServices(),
usageCollector: data.search.usageCollector,
}),
getQueryString: (currentQuery: Query) => `source = ${currentQuery.dataset?.title}`,
getQueryString: (currentQuery: Query) => `source = ${currentQuery.dataset?.title} | head 10`,
fields: { filterable: false, visualizable: false },
docLink: {
title: i18n.translate('queryEnhancements.pplLanguage.docLink', {
Expand Down
Loading