Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure discover table headers have a min width #8927

Closed
wants to merge 2 commits into from

Conversation

d-rowe
Copy link
Member

@d-rowe d-rowe commented Nov 26, 2024

Description

This is a stopgap measure to ensure a minimum header width in the Discover table have enough space to properly render.

Screenshot

Before

Screenshot 2024-11-25 at 7 09 03 PM

After

Screenshot 2024-11-25 at 7 07 35 PM

Testing the changes

Changelog

  • fix: add min-width to discover table header

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Daniel Rowe <rowdane@amazon.com>
Copy link
Contributor

❌ Invalid Prefix

Invalid description prefix. Found "style". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (539675e) to head (7cd02d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8927      +/-   ##
==========================================
- Coverage   60.88%   60.87%   -0.01%     
==========================================
  Files        3802     3802              
  Lines       91070    91070              
  Branches    14374    14374              
==========================================
- Hits        55444    55442       -2     
- Misses      32085    32086       +1     
- Partials     3541     3542       +1     
Flag Coverage Δ
Linux_1 29.02% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.89% <ø> (-0.01%) ⬇️
Linux_4 29.00% <ø> (ø)
Windows_1 29.03% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <ø> (-0.01%) ⬇️
Windows_4 29.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki
Copy link
Collaborator

Thanks Daniel for the quick turnaround. Just nit-picking here:

Before

d.before.mp4

After

d.after.mp4

@d-rowe
Copy link
Member Author

d-rowe commented Nov 26, 2024

Closing in favor of more robust solution in #8928

@d-rowe d-rowe closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants