-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add id attribute to search bar #338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
nung22
requested review from
macohen,
mingshl,
msfroh,
noCharger and
sejli
as code owners
October 24, 2023 16:53
Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 83.46% 87.08% +3.62%
==========================================
Files 32 16 -16
Lines 393 209 -184
Branches 77 43 -34
==========================================
- Hits 328 182 -146
+ Misses 45 26 -19
+ Partials 20 1 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sejli
approved these changes
Nov 8, 2023
Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
…levance into fix/add-searchbar-id
github-actions bot
added a commit
that referenced
this pull request
Nov 29, 2023
* Add id to search bar Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add keys to getDlTmpl component Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Change enclosing tag to span instead of div Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> --------- Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> (cherry picked from commit c64b9f5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Add id to search bar * Add keys to getDlTmpl component * Change enclosing tag to span instead of div --------- (cherry picked from commit c64b9f5) Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nung22
added a commit
to nung22/dashboards-search-relevance
that referenced
this pull request
Nov 29, 2023
* Add id to search bar Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add keys to getDlTmpl component Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Change enclosing tag to span instead of div Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> --------- Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
sejli
pushed a commit
that referenced
this pull request
Jan 26, 2024
…352) * Add search pipeline parameters to index and route files Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add search pipeline dropdown Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Integrate option to select search pipeline Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update tests and snapshots Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update get pipelines endpoint Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update .babelrc Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update test snapshots Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add id attribute to search bar (#338) * Add id to search bar Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add keys to getDlTmpl component Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Change enclosing tag to span instead of div Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> --------- Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update .babelrc Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add ability to select _none option Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update test coverages Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update variables in pipeline selection Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> --------- Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
github-actions bot
added a commit
that referenced
this pull request
Jan 26, 2024
…352) * Add search pipeline parameters to index and route files Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add search pipeline dropdown Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Integrate option to select search pipeline Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update tests and snapshots Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update get pipelines endpoint Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update .babelrc Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update test snapshots Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add id attribute to search bar (#338) * Add id to search bar Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add keys to getDlTmpl component Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Change enclosing tag to span instead of div Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> --------- Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update .babelrc Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add ability to select _none option Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update test coverages Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update variables in pipeline selection Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> --------- Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> (cherry picked from commit 29e5867) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
that referenced
this pull request
Jan 26, 2024
…352) (#362) * Add search pipeline parameters to index and route files * Add search pipeline dropdown * Integrate option to select search pipeline * Update tests and snapshots * Update get pipelines endpoint * Update .babelrc * Update test snapshots * Add id attribute to search bar (#338) * Add id to search bar * Add keys to getDlTmpl component * Change enclosing tag to span instead of div --------- * Update .babelrc * Add ability to select _none option * Update test coverages * Update variables in pipeline selection --------- (cherry picked from commit 29e5867) Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that
OuiFieldSearch
was raising the suggested improvement: "A form field element should have anid
orname
attribute". Added theid
"searchRelevance-searchBar" to the component, which resolves the issue. Also fixes a uniquekey
error that was being generated by thegetDlTmpl
component ofResultGridComponent
.Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screenshots