Sort Index Dropdown and Implement ComboBox #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 24, 2023 18:57
Signed-off-by: Frank Schlehofer <franklschlehofer@gmail.com>
Signed-off-by: Frank Schlehofer <franklschlehofer@gmail.com>
Signed-off-by: Frank Schlehofer <franklschlehofer@gmail.com>
…nal onChangeSelectedIndex Signed-off-by: Frank Schlehofer <franklschlehofer@gmail.com>
Implements the ComboBox that allows search functionality for the indexes. This also sorts the documentsIndexes array.
Signed-off-by: Frank Schlehofer <franklschlehofer@gmail.com>
frankschlehofer
requested review from
macohen,
mingshl,
msfroh,
noCharger and
sejli
as code owners
|
@frankschlehofer can you use the Its used in the Data Explorer plugin like this: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data_explorer/public/components/sidebar/index.tsx#L96-L103 Any future updates to how data sources are handled will be taken care of here :) |
|
Going to close this now, since we have more work being done on #358. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change sorts the index dropdown. It also uses a ComboBox to add search functionality.
Issues Resolved
Closes #293
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.