Index Management Action Metrics #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 11, 2024 12:50
Signed-off-by: harycash <harycash@amazon.com>
Signed-off-by: harycash <harycash@amazon.com>
… Integration Signed-off-by: harycash <harycash@amazon.com>
… Integration Signed-off-by: harycash <harycash@amazon.com>
Signed-off-by: harycash <harycash@amazon.com>
harshitakaushik-dev
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt,
jowg-amazon,
r1walz and
vikasvb90
as code owners
|
@bowenlan-amzn @Gaganjuneja @sarthakaggarwal97 @vikasvb90 @r1walz @ankitkala |
1 task
harshitakaushik-dev
changed the title
Signed-off-by: harycash <harycash@amazon.com>
Signed-off-by: harycash <harycash@amazon.com>
Signed-off-by: harycash <harycash@amazon.com>
spi/src/main/kotlin/org.opensearch.indexmanagement.spi/indexstatemanagement/Step.kt
Outdated
Show resolved
Hide resolved
...search.indexmanagement.spi/indexstatemanagement/metrics/actionmetrics/DeleteActionMetrics.kt
Show resolved
Hide resolved
...ch.indexmanagement.spi/indexstatemanagement/metrics/actionmetrics/TransitionActionMetrics.kt
Show resolved
Hide resolved
...opensearch.indexmanagement.spi/indexstatemanagement/metrics/IndexManagementActionsMetrics.kt
Show resolved
Hide resolved
Signed-off-by: harycash <harycash@amazon.com>
added 4 commits
July 1, 2024 21:43
Signed-off-by: harycash <harycash@amazon.com>
Signed-off-by: harycash <harycash@amazon.com>
Signed-off-by: harycash <harycash@amazon.com>
Signed-off-by: harycash <harycash@amazon.com>
spi/src/main/kotlin/org.opensearch.indexmanagement.spi/indexstatemanagement/Step.kt
Show resolved
Hide resolved
spi/src/main/kotlin/org.opensearch.indexmanagement.spi/indexstatemanagement/Step.kt
Outdated
Show resolved
Hide resolved
...opensearch.indexmanagement.spi/indexstatemanagement/metrics/IndexManagementActionsMetrics.kt
Outdated
Show resolved
Hide resolved
...lin/org/opensearch/indexmanagement/indexstatemanagement/step/rollover/AttemptRolloverStep.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: harycash <harycash@amazon.com>
harshitakaushik-dev
force-pushed
the
additional-metrics
branch
from
9ab10b5
to
4d6176f
Compare
sarthakaggarwal97
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
thanks @harshitakaushik-dev for taking this up. This would be really useful!
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1195-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c5425a52e6e7d5fd0f87bf770436527c8911ee08
# Push it to GitHub
git push --set-upstream origin backport/backport-1195-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.xThen, create a pull request where the |
sarthakaggarwal97
added
enhancement
harshitakaushik-dev
added a commit
to harshitakaushik-dev/index-management
that referenced
this pull request
Jul 4, 2024
* Initial integration of TelemetryAwarePlugin to ISM Signed-off-by: harycash <harycash@amazon.com> * Initial integration of TelemetryAwarePlugin to ISM Signed-off-by: harycash <harycash@amazon.com> * Initial integration of TelemetryAwarePlugin to ISM with Rollover Step Integration Signed-off-by: harycash <harycash@amazon.com> * Initial integration of TelemetryAwarePlugin to ISM with Rollover Step Integration Signed-off-by: harycash <harycash@amazon.com> * Additional actions metrics with requested changes from previous commit Signed-off-by: harycash <harycash@amazon.com> * Fixed Build Issues Signed-off-by: harycash <harycash@amazon.com> * Fixed Build Issues Signed-off-by: harycash <harycash@amazon.com> * Fixed Build Issues, Added new metric : Cumulative Latency Signed-off-by: harycash <harycash@amazon.com> * Fixed Build Issues, Added new metric : Cumulative Latency Signed-off-by: harycash <harycash@amazon.com> * Requested Changes and Addition of Metrics to all the remaining Actions Signed-off-by: harycash <harycash@amazon.com> * Updates on Action Metrics Signed-off-by: harycash <harycash@amazon.com> * Updates on Action Metrics Signed-off-by: harycash <harycash@amazon.com> * Build issues fixed Signed-off-by: harycash <harycash@amazon.com> * Build issues fixed Signed-off-by: harycash <harycash@amazon.com> --------- Signed-off-by: harycash <harycash@amazon.com> Co-authored-by: harycash <harycash@amazon.com> (cherry picked from commit c5425a5) Signed-off-by: harycash <harycash@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@bowenlan-amzn I have made the requested changes in the code as per your feedback. Could you kindly review it again? I will add the changes to the tests in the next iteration.
Here are the metrics results we have on Grafana with the OpenTelemetry (Otel) setup. Attached are metrics for Transition Cumulative Latency and Rollover Failure.
