Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto managed index always have -2 seqNo bug #929

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Sep 8, 2023

Issue #, if available:

Description of changes:

ISM has a function to auto manage the newly created index, however, we found in this path, the managed index created is always having policy seqNo set as -2, this is because the policy search request doesn't require seqNo back so it's always default to -2. This PR adds it back

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #929 (8147743) into main (a2dd769) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #929      +/-   ##
============================================
+ Coverage     75.55%   75.68%   +0.12%     
- Complexity     2842     2846       +4     
============================================
  Files           364      364              
  Lines         16263    16263              
  Branches       2343     2343              
============================================
+ Hits          12288    12309      +21     
+ Misses         2626     2610      -16     
+ Partials       1349     1344       -5     
Files Changed Coverage Δ
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 71.18% <100.00%> (+2.08%) ⬆️
...t/action/indexpolicy/TransportIndexPolicyAction.kt 80.95% <100.00%> (ø)

... and 11 files with indirect coverage changes

@bowenlan-amzn bowenlan-amzn merged commit 65d2218 into opensearch-project:main Oct 3, 2023
@bowenlan-amzn bowenlan-amzn deleted the fixseqNo-2main branch October 3, 2023 17:01
Joshua152 pushed a commit to Joshua152/index-management that referenced this pull request Oct 10, 2023
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants