Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct index mapping types #666

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Nov 12, 2024

Description

Correct index mapping types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Changes Analysis

Commit SHA: 7aa99de
Comparing To SHA: 0871d02

API Changes

Summary

├─┬Paths
│ ├─┬/_index_template/{name}
│ │ ├─┬PUT
│ │ │ └─┬Requestbody
│ │ │   └─┬application/json
│ │ │     └─┬Schema
│ │ │       └─┬priority
│ │ │         └──[🔀] type (26135:23)❌ 
│ │ └─┬POST
│ │   └─┬Requestbody
│ │     └─┬application/json
│ │       └─┬Schema
│ │         └─┬priority
│ │           └──[🔀] type (26135:23)❌ 
│ └─┬/_index_template/_simulate_index/{name}
│   └─┬POST
│     └─┬Requestbody
│       └─┬application/json
│         └─┬Schema
│           └─┬priority
│             └──[🔀] type (26315:23)❌ 
└─┬Components
  ├──[➖] schemas (49173:7)❌ 
  ├──[➖] schemas (39604:7)❌ 
  ├──[➖] schemas (39037:7)❌ 
  ├──[➖] schemas (39050:7)❌ 
  ├──[➖] schemas (39817:7)❌ 
  ├──[➖] schemas (39175:7)❌ 
  ├──[➖] schemas (39904:7)❌ 
  ├──[➕] schemas (39256:7)
  ├─┬_common.mapping___Property
  │ ├──[➖] oneOf (39989:7)❌ 
  │ ├──[➖] oneOf (39126:7)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39941:24)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39653:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39547:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39666:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39257:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39155:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (38971:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (38883:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (38995:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39384:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39516:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39959:24)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39452:9)❌ 
  │ ├─┬ONEOF
  │ │ └──[🔀] $ref (39918:9)❌ 
  │ └─┬ONEOF
  │   └──[🔀] $ref (39092:9)❌ 
  ├─┬indices._common___IndexTemplate
  │ └─┬priority
  │   ├──[🔀] type (49116:17)❌ 
  │   └──[➕] format (49117:19)❌ 
  ├─┬_core.field_caps___FieldCapability
  │ ├──[➖] properties (42384:9)❌ 
  │ ├──[➖] properties (42377:9)❌ 
  │ ├──[➖] properties (42372:9)❌ 
  │ └──[➖] properties (42375:9)❌ 
  ├─┬_common.mapping___IpProperty
  │ └─┬ALLOF
  │   ├──[➖] properties (39372:13)❌ 
  │   ├──[➖] properties (39374:13)❌ 
  │   └──[➖] properties (39376:13)❌ 
  ├─┬indices._common___IndexSettings
  │ └──[➖] properties (48834:9)❌ 
  ├─┬_common.mapping___KeywordProperty
  │ └─┬ALLOF
  │   └──[➖] properties (39439:13)❌ 
  ├─┬_common.mapping___NumberPropertyBase
  │ └─┬ALLOF
  │   ├──[➖] properties (39583:13)❌ 
  │   ├──[➖] properties (39585:13)❌ 
  │   ├──[➖] properties (39589:13)❌ 
  │   └──[➖] properties (39587:13)❌ 
  └─┬_common.mapping___AggregateMetricDoubleProperty
    └─┬ALLOF
      └──[➖] properties (38832:13)❌ 

Document Element Total Changes Breaking Changes
paths 3 3
components 41 49
  • BREAKING Changes: 52 out of 44
  • Modifications: 19
  • Removals: 23
  • Additions: 2
  • Breaking Removals: 23
  • Breaking Modifications: 19
  • Breaking Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11825892694/artifacts/2184419706

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 40 40 0

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Spec Test Coverage Analysis

Total Tested
515 347 (67.38 %)

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix linter.

Add a test, at least one that exercises the added IcuCollationKeywordProperty?

spec/schemas/_common.mapping.yaml Outdated Show resolved Hide resolved
spec/schemas/_common.mapping.yaml Show resolved Hide resolved
@dblock
Copy link
Member

dblock commented Nov 13, 2024

Rebase?

Also in #609 @rursprung is adding an analysis plugin test like this one. Should we combine them into one analysis folder or not?

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia requested a review from dblock November 13, 2024 21:14
@dblock dblock merged commit 6065144 into opensearch-project:main Nov 13, 2024
26 checks passed
@Xtansia Xtansia deleted the fix/mapping-types branch November 13, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants