Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix remaining /_ingest paths. #689

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 22, 2024

Description

  • Add s parameter to /_ingest/processor/grok.
  • Fix /_ingest/pipeline/{id}/_simulate response doc/_source field schema.

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the ingest-pipeline-processor branch from 3dbad73 to e63d8ac Compare November 22, 2024 18:53
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Changes Analysis

Commit SHA: 16a4805
Comparing To SHA: 7e08a43

API Changes

Summary

├─┬Paths
│ └─┬/_ingest/processor/grok
│   └─┬GET
│     └──[➕] parameters (21667:13)❌ 
└─┬Components
  ├──[➕] parameters (21667:7)
  └─┬ingest.simulate___DocumentSimulation
    └─┬_source
      └──[🔀] additionalProperties (51995:33)❌ 

Document Element Total Changes Breaking Changes
components 2 1
paths 1 1
  • BREAKING Changes: 2 out of 3
  • Modifications: 1
  • Additions: 2
  • Breaking Modifications: 1
  • Breaking Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11999916007/artifacts/2230332325

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Spec Test Coverage Analysis

Total Tested
528 384 (72.73 %)

Xtansia
Xtansia previously approved these changes Nov 24, 2024
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia merged commit c51aa2e into opensearch-project:main Nov 24, 2024
27 checks passed
@dblock dblock deleted the ingest-pipeline-processor branch November 25, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants