Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed /_index_template/_simulate*. #691

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 25, 2024

Description

Fixed /_index_template/_simulate*, added tests.

Issues Resolved

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Changes Analysis

Commit SHA: 73d547d
Comparing To SHA: c888a16

API Changes

Summary

├─┬Paths
│ └─┬/_index_template/_simulate_index/{name}
│   └─┬POST
│     ├──[➖] parameters (21167:13)❌ 
│     └──[➖] parameters (21183:13)❌ 
└─┬Components
  ├──[➖] parameters (21182:7)❌ 
  ├──[➖] parameters (21167:7)❌ 
  └─┬indices.simulate_template___Template
    └──[➖] required (50809:11)❌ 

Document Element Total Changes Breaking Changes
paths 2 2
components 3 3
  • BREAKING Changes: 5 out of 5
  • Removals: 5
  • Breaking Removals: 5

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12036128911/artifacts/2240351807

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

Signed-off-by: dblock <dblock@amazon.com>
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Spec Test Coverage Analysis

Total Tested
528 400 (75.76 %)

nhtruong
nhtruong previously approved these changes Nov 26, 2024
Signed-off-by: Theo N. Truong <theotr@amazon.com>
@dblock dblock merged commit 610557a into opensearch-project:main Nov 26, 2024
27 checks passed
@dblock dblock deleted the simulate-tests branch November 26, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants